ItemProjector : Fix checking for actual "machineId" NBT tag instead of checking for any NBT data #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Putting this on hold until new code gets merged, as it rolls over quite a few things with a steamroller including the projector. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to make a modpack and was stumbling upon a very weird crash.
I narrowed it down to this :
There was a mod in my list (I still don't know which) that was adding a "temperature" NBT tag to the ItemProjector stack.
When entering ItemProjector.addInformation(), getMachineId returned 0 (the default value since the NBT tag "machineId" was not present) instead of returning -1.
This was because getMachineId only checks if there is any NBT data at all, and not if the tag "machineid" is set.
This simple addition will fix that.
Side note, I still don't know what is adding the mysterious "temperature" tag to the item.